datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-3558] Add e2e tests for APM origin detection

Open AliDatadog opened this issue 1 year ago • 5 comments

What does this PR do?

This PR adds e2e tests for origin detection on APM.

Motivation

Increase test coverage.

Additional Notes

N/A

Possible Drawbacks / Trade-offs

N/A

Describe how to test/QA your changes

Run tests using inv new-e2e-tests.run --targets=./tests/containers --run TestKindSuite

=== RUN   TestKindSuite/TestTraceTCP
=== RUN   TestKindSuite/TestTraceUDP

AliDatadog avatar Feb 19 '24 16:02 AliDatadog

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 7beef838-ee85-4b76-91ac-af28fbf4b2cb Baseline: 9898528046a1a281bb76e22ae55f5e7f963bfb01 Comparison: 0cc41ee5aafe15281360e713d3928c7ebc57dd8d

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -2.06 [-8.56, +4.44]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.31 [+0.68, +1.93]
process_agent_real_time_mode memory utilization +0.12 [+0.08, +0.15]
file_tree memory utilization +0.04 [-0.03, +0.11]
process_agent_standard_check_with_stats memory utilization +0.04 [+0.01, +0.07]
trace_agent_json ingress throughput +0.03 [+0.01, +0.06]
trace_agent_msgpack ingress throughput +0.03 [+0.01, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
process_agent_standard_check memory utilization -0.03 [-0.05, -0.00]
tcp_syslog_to_blackhole ingress throughput -0.14 [-0.19, -0.09]
idle memory utilization -0.40 [-0.43, -0.37]
uds_dogstatsd_to_api_cpu % cpu utilization -0.48 [-1.92, +0.95]
basic_py_check % cpu utilization -0.62 [-2.81, +1.56]
file_to_blackhole % cpu utilization -2.06 [-8.56, +4.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 19 '24 17:02 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Feb 21 '24 15:02 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #28643033

dd-devflow[bot] avatar Feb 21 '24 15:02 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Mar 01 '24 14:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #29296220

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

/trigger-ci --variable RUN_E2E_TESTS=true

AliDatadog avatar Mar 08 '24 09:03 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #29787400

dd-devflow[bot] avatar Mar 08 '24 09:03 dd-devflow[bot]

/merge

AliDatadog avatar Mar 08 '24 13:03 AliDatadog

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 08 '24 13:03 dd-devflow[bot]