Allow filtering files and programs when showing verification statistics
What does this PR do?
This PR allows a user to pass a file filter and a program filter to selectively show the verification statistics of eBPF programs.
Motivation
Improves feedback time and eases analysis.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 9b26763c-582c-49e4-807d-de10b837e65f Baseline: 291dd37ff5b861a25c3972701321c18ec551acb5 Comparison: be70051549d97ce3fa62f19b34c3a6c211a378c8 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
Experiments with missing or malformed data
- basic_py_check
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.57 | [-5.99, +7.13] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +1.11 | [+0.99, +1.23] |
| ➖ | otel_to_otel_logs | ingress throughput | +1.01 | [+0.33, +1.70] |
| ➖ | file_to_blackhole | % cpu utilization | +0.57 | [-5.99, +7.13] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.54 | [+0.49, +0.60] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.34 | [+0.29, +0.39] |
| ➖ | process_agent_standard_check | memory utilization | +0.34 | [+0.29, +0.38] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.22 | [+0.17, +0.26] |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.03, +0.06] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.01, +0.01] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.48 | [-1.89, +0.93] |
| ➖ | idle | memory utilization | -0.55 | [-0.60, -0.51] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Nice @usamasaqib ! Thanks for that!
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 10 builds ahead! (estimated merge in less than 3h)
Use /merge -c to cancel this operation!
:rotating_light: MergeQueue
mergequeue build completed successfully, but the github api returned an error while merging the pr. It's probably because:
- repository configuration requires approval by code owners, but no code owner approved this PR
Details
Error: PUT https://api.github.com/repos/DataDog/datadog-agent/pulls/22879/merge: 405 Merge already in progress []
FullStacktrace: activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-d79757f58-ql96k@): PUT https://api.github.com/repos/DataDog/datadog-agent/pulls/22879/merge: 405 Merge already in progress [] (type: ErrorResponse, retryable: true)
If you need support, contact us on Slack #ci-interfaces with those details!
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue
Added to the queue.
This build is next! (estimated merge in less than 48m)
Use /merge -c to cancel this operation!