datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CI/Tooling] Remove Windows 32 bits usecase in the invoke tasks

Open amenasria opened this issue 2 years ago • 1 comments

What does this PR do?

This PR removes the Windows 32 bits usecase in the invoke tasks.

Motivation

Follow-up of #21221. The Agent does not support Windows 32 bits.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

amenasria avatar Dec 01 '23 13:12 amenasria

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4cccc54c-67b3-4d25-825c-8827b933041e Baseline: 8d536e589b0f57cd6f433e1d86e010e2bebedcfe Comparison: ee49c4dd92f25f6e1c6876a29528c8358aac4feb Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ denotes better comparison variant performance
  • ❌ denotes worse comparison variant performance

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput +1.16 [+0.47, +1.86] 99.39%

Experiments with missing or malformed data

  • idle

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput +1.16 [+0.47, +1.86] 99.39%
file_to_blackhole egress throughput +0.01 [-6.15, +6.18] 0.25%
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
trace_agent_json ingress throughput +0.00 [-0.01, +0.01] 0.00%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.00, +0.00] 0.00%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_100k ingress throughput -0.00 [-0.04, +0.03] 13.56%
tcp_syslog_to_blackhole ingress throughput -0.09 [-0.15, -0.03] 98.25%
file_tree egress throughput -0.19 [-1.97, +1.59] 13.97%

pr-commenter[bot] avatar Dec 07 '23 12:12 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 048fc903-83d8-4dd1-8501-b44eaf8626d3 Baseline: 213682e97e1b6a265c00b46e6f66874d939d434a Comparison: 22cf26144b1b1eac6e7f4ec13287bde6845f2542

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +1.60 [-3.37, +6.56]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.04, +0.04]
otel_to_otel_logs ingress throughput -0.00 [-0.36, +0.35]
idle memory utilization -0.13 [-0.16, -0.10]
file_tree memory utilization -0.53 [-0.63, -0.44]
uds_dogstatsd_to_api_cpu % cpu utilization -0.57 [-3.34, +2.21]
basic_py_check % cpu utilization -1.88 [-4.26, +0.51]
tcp_syslog_to_blackhole ingress throughput -2.52 [-23.52, +18.49]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Apr 29 '24 13:04 pr-commenter[bot]

/merge

amenasria avatar May 06 '24 11:05 amenasria

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar May 06 '24 11:05 dd-devflow[bot]

/merge -c

amenasria avatar May 06 '24 11:05 amenasria

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar May 06 '24 11:05 dd-devflow[bot]

/merge

amenasria avatar May 06 '24 11:05 amenasria

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar May 06 '24 11:05 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar May 06 '24 15:05 dd-devflow[bot]

/merge

amenasria avatar May 16 '24 07:05 amenasria

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar May 16 '24 07:05 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar May 16 '24 11:05 dd-devflow[bot]

/merge

amenasria avatar May 22 '24 14:05 amenasria

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 29m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar May 22 '24 14:05 dd-devflow[bot]