datadog-agent
datadog-agent copied to clipboard
[NDM] Netflow status formatting changes
What does this PR do?
Updates the formatting in the status page in both the GUI and CLI for NDM Netflow. The functionality should be exactly the same, but the spacing has been adjusted to match other integrations.
Motivation
Noticed the spacing wasn't the same as other integrations during QA. See the updated formatting below:
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
QA this change by adding a few Netflow listeners to your config:
network_devices:
netflow:
enabled: true
listeners:
- flow_type: netflow5
workers: 4
port: 2056
- flow_type: ipfix
port: 5023
- flow_type: netflow9
port: 4066
- flow_type: sflow5
workers: 7
port: 4077
To check closed listeners, bind an application to UDP on one or more of the ports configured in datadog.yaml. You can use this program to block UDP ports: https://gist.github.com/ken-schneider/c9fba5d8ba5b8cd82f007f31b7e69a48
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [ ] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [ ] A release note has been added or the
changelog/no-changeloglabel has been applied. - [ ] Changed code has automated tests for its functionality.
- [ ] Adequate QA/testing plan information is provided if the
qa/skip-qalabel is not applied. - [ ] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.