datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

New Windows installer add unit tests

Open julien-lebot opened this issue 3 years ago • 0 comments

What does this PR do?

This PR adds unit tests for the next-gen Windows installer. It uses xUnit with Moq for the mocking framework, and AutoFixtures for generating sample data.

Motivation

Better test coverage.

Additional Notes

This PR also introduces an interface ISession that proxies the real Session object for unit testing purposes.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

julien-lebot avatar Oct 07 '22 18:10 julien-lebot