chaos-controller icon indicating copy to clipboard operation
chaos-controller copied to clipboard

Profiler: wrapper zap logger for datadog tracer agent

Open nathantournant opened this issue 2 years ago • 2 comments

What does this PR do?

  • [ ] Adds new functionality
  • [X] Alters existing functionality
  • [ ] Fixes a bug
  • [ ] Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • The datadog logger interface is simple but did not fit the zap logger we used. This provides a wrapper that puts all tracer/profiler logs in our usual zap SugaredLogger, providing the usual tags / logging context, and very basic info/warn/error level parsing. The parsing allows to not receive tracer/profiler startup logs (and warnings) as errors, but set to the appropriate levels.

Code Quality Checklist

  • [X] The documentation is up to date.
  • [X] My code is sufficiently commented and passes continuous integration checks.
  • [X] I have signed my commit (see Contributing Docs).

Testing

  • [X] I leveraged continuous integration testing
    • [X] by depending on existing unit tests or end-to-end tests.
    • [ ] by adding new unit tests or end-to-end tests.
  • [X] I manually tested the following steps:

nathantournant avatar Jun 15 '23 14:06 nathantournant

Datadog Report

Branch report: nathan/CHAOS-653/fix-profiler-setup Commit report: ccdbd4f

:white_check_mark: chaos-controller: 0 Failed, 0 New Flaky, 477 Passed, 0 Skipped, 2m 50.44s Wall Time

Datadog Report

Branch report: nathan/CHAOS-653/fix-profiler-setup Commit report: 6160b9e

:snowflake: chaos-controller: 0 Failed, 3 New Flaky, 483 Passed, 0 Skipped, 5m 36.8s Wall Time

New Flaky Tests (3)

  • [It] Cache Handler verify events sent should not fire any warning event on disruption - Controller Suite - Last Failure

    Expand for error
    imed out after 35.232s.
    xpected success, but got an error:
       <*errors.StatusError | 0xc0006741e0>: 
       disruptions.chaos.datadoghq.com "ee77f2bb-649a-4605-9396-a40d79172006-lqqwp" not found
       {
           ErrStatus: {
               TypeMeta: {Kind: "", APIVersion: ""},
               ListMeta: {
                   SelfLink: "",
                   ResourceVersion: "",
    ..
    
  • [It] Disruption Controller disruption expires naturally should target all the selected pods - Controller Suite - Last Failure

    Expand for error
    imed out after 73.087s.
    xpected success, but got an error:
       <*errors.StatusError | 0xc0003254a0>: 
       disruptions.chaos.datadoghq.com "f31090f4-7555-4e41-b102-188112321550-xv8zd" not found
       {
           ErrStatus: {
               TypeMeta: {Kind: "", APIVersion: ""},
               ListMeta: {
                   SelfLink: "",
                   ResourceVersion: "",
    ..
    
  • [It] Disruption Controller Injection Statuses disruption expired statuses PreviouslyInjected is reached after PausedInjected and stays until disruption expires - Controller Suite - Last Failure

    Expand for error
    imed out after 59.554s.
    xpected success, but got an error:
       <*errors.StatusError | 0xc000b526e0>: 
       disruptions.chaos.datadoghq.com "4f6c9f49-e300-492a-bccc-567bf38e1ca9-78qxg" not found
       {
           ErrStatus: {
               TypeMeta: {Kind: "", APIVersion: ""},
               ListMeta: {
                   SelfLink: "",
                   ResourceVersion: "",
    ..
    

oudated.

nathantournant avatar Jan 29 '25 10:01 nathantournant