chaos-controller icon indicating copy to clipboard operation
chaos-controller copied to clipboard

fix: change readiness event type to normal chaos-349

Open aymericDD opened this issue 3 years ago • 0 comments

What does this PR do?

  • [ ] Adds new functionality
  • [ ] Alters existing functionality
  • [x] Fixes a bug
  • [ ] Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • Change the event type of EventReadinessProbeChange to warning only if the disruption status has the DisruptionStatusNotInjected state or if the disruption is not already disrupted. The idea is to avoid spam user with warning alerts.

Code Quality Checklist

  • [ ] The documentation is up to date.
  • [ ] My code is sufficiently commented and passes continuous integration checks.
  • [ ] I have signed my commit (see Contributing Docs).

Testing

  • [ ] I leveraged continuous integration testing
    • [ ] by depending on existing unit tests or end-to-end tests.
    • [x] by adding new unit tests or end-to-end tests.
  • [ ] I manually tested the following steps:
    • x
    • [ ] locally.
    • [ ] as a canary deployment to a cluster.

aymericDD avatar Oct 18 '22 08:10 aymericDD