browser-sdk icon indicating copy to clipboard operation
browser-sdk copied to clipboard

✨[RUM-4178] Report memory impact to Datadog

Open rgaignault opened this issue 1 year ago • 5 comments

Motivation

We would like to see the impact of a PR on memory and detect regressions early

Changes

So I added a script to report memory performance both in datadog logs and dashboard :

image

I also added a section in the pr comment about memory.

Testing

  • [ ] Local
  • [ ] Staging
  • [ ] Unit
  • [ ] End to end

I have gone over the contributing documentation.

rgaignault avatar Apr 24 '24 15:04 rgaignault

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.14 KiB 157.14 KiB 0 B 0.00%
Logs 56.26 KiB 56.26 KiB 0 B 0.00%
Rum Slim 103.69 KiB 103.69 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.001
addaction 0.017 0.016 -0.002
adderror 0.036 0.032 -0.004
addtiming 0.001 0.001 -0.000
startview 0.923 0.837 -0.086
startstopsessionreplayrecording 0.771 0.713 -0.058
logmessage 0.006 0.005 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫
addglobalcontext NaN KiB 26.55 KiB NaN KiB
addaction NaN KiB 47.79 KiB NaN KiB
adderror NaN KiB 50.12 KiB NaN KiB
addtiming NaN KiB 9.15 KiB NaN KiB
startview NaN KiB 2025.89 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 10.61 KiB NaN KiB
logmessage NaN KiB 60.14 KiB NaN KiB

cit-pr-commenter[bot] avatar Apr 24 '24 15:04 cit-pr-commenter[bot]

/to-staging

rgaignault avatar Apr 26 '24 11:04 rgaignault

:steam_locomotive: Branch Integration: starting soon, merge in < 9m

Commit ee3a2a747c will soon be integrated into staging-17.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-devflow[bot] avatar Apr 26 '24 11:04 dd-devflow[bot]

:steam_locomotive: Branch Integration: This commit was successfully integrated

Commit ee3a2a747c has been merged into staging-17 in merge commit 2277d128da.

Check out the triggered pipeline on Gitlab :fox_face:

dd-devflow[bot] avatar Apr 26 '24 11:04 dd-devflow[bot]

/to-staging

rgaignault avatar May 27 '24 09:05 rgaignault

:steam_locomotive: Branch Integration: starting soon, merge in < 0s

Commit e4b5e6f2cc will soon be integrated into staging-22.

This build is going to start soon! (estimated merge in less than 0s)

Use /to-staging -c to cancel this operation!

dd-devflow[bot] avatar May 27 '24 09:05 dd-devflow[bot]

:steam_locomotive: Branch Integration: This commit was successfully integrated

Commit e4b5e6f2cc has been merged into staging-22 in merge commit a480bef44a.

Check out the triggered pipeline on Gitlab :fox_face:

dd-devflow[bot] avatar May 27 '24 10:05 dd-devflow[bot]