apigentools icon indicating copy to clipboard operation
apigentools copied to clipboard

Apply templates patches in Git repo with --commit-patches option

Open jirikuncar opened this issue 5 years ago • 1 comments

What does this PR do?

Applies commit patches in Git repository for easier modification of patches.

Description of the Change

Adds option --commit-patches to apigentools templates command.

Alternate Designs

Possible Drawbacks

The template patches do not contain path prefix based on openapi-generator. It can be considered advantage as we had witnessed change of template folder from go-experimental to go.

Verification Process

Additional Notes

Update template patches:

$ cd templates/<lang>/<version>
$ git log --pretty=format:"%H:%s" --reverse | tail -n +2 | while IFS=: read -r commit file; do git diff $commit^..$commit > ../../../$file; done

Get list of template patches for a language:

$ cd templates/<lang>/<version>
$ git log --pretty=format:"- %s" --reverse | tail -n +2

Release Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • [ ] PR should not have do-not-merge/ label attached.
  • [ ] If Applicable, issue must have kind/ and severity/ labels attached at least.

jirikuncar avatar Feb 02 '21 09:02 jirikuncar

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

github-actions[bot] avatar Apr 05 '21 00:04 github-actions[bot]