KCEF icon indicating copy to clipboard operation
KCEF copied to clipboard

Fix icons in README by using old version as source

Open sebkur opened this issue 1 year ago • 4 comments

The Windows icon has been removed in a recent version of simple icons, but it can still be obtained from older versions of the library on some of the CDNs.

sebkur avatar Oct 16 '24 08:10 sebkur

Screenshot from 2024-10-16 10-59-30

^- this just makes the project look so abandoned on first sight.

sebkur avatar Oct 16 '24 09:10 sebkur

This is a workaround for this: https://github.com/simple-icons/simple-icons/pull/10019

sebkur avatar Oct 16 '24 09:10 sebkur

Oh, I didn't realize that feature of simple-icons own CDN was in use here. Hmm, unfortunately, the other CDNs don't seem to support this. Thinking about other workarounds, but cannot seem to find any at the moment. Sorry, don't have a solution for this then, feel free to close...

sebkur avatar Oct 16 '24 09:10 sebkur

I've been looking around a bit and found out that there are ways to include html in github markdown and it's even possible to select images based on the dark/light theme: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

So it's possible to exchange the image based on theme, here's some experimental code: https://github.com/sebkur/KCEF/commit/c4418d9932f7c72f6735e0618689b3981cf1f61f visible at https://github.com/sebkur/KCEF/tree/fix-icons2

In the example for the sake of trying things out, I'm using the windows icon for light mode and the linux icon for dark mode. That works. So if we had a source of each image with white fill, we could swap them out based on the theme. But that's the problem of course, we don't have that...

It's interesting though, the SVG files don actually specify an fill color, so they default to black. It's even possible to use some css in the embedded html, however it does not look like we can manipulate the svg coloring from the embedding html.

sebkur avatar Oct 18 '24 08:10 sebkur