dasharo-issues icon indicating copy to clipboard operation
dasharo-issues copied to clipboard

Internal keyboard sometimes does not work in firmware

Open Pokisiekk opened this issue 3 years ago • 24 comments

Dasharo version v1.4.0

Dasharo variant NS5x/7xPU

Affected component(s) or functionality internal keyboard

Brief summary Internal keyboard stops working in BIOS after pressing ESC many times.

How reproducible ~7%

How to reproduce

Steps to reproduce the behavior:

  1. Power on the DUT.
  2. Press the ESC button as fast as possible.

Expected behavior Setup menu is displayed. Internal keyboard works.

Actual behavior Setup menu is displayed. Internal keyboard does not work.

Pokisiekk avatar Dec 20 '22 10:12 Pokisiekk

The same problem with NV41PZ, Dasharo 1.4.0. Problem is not even with entering to setup, but also in choosing one-time boot device. Backlight in keyboard works correctly, so keyboard seems to be alive, but system does not respond to it.

3mdeb-karolzmyslowski avatar Feb 15 '23 13:02 3mdeb-karolzmyslowski

Will this be solved in next firmware releases? So far, we have only seen this bug for Alder Lake devices.

wessel-novacustom avatar Mar 10 '23 08:03 wessel-novacustom

A way to workaround this bug:

  1. Shut down the laptop.
  2. Remove the power supply for at least 10 seconds.
  3. Re-attach the power supply and startup the laptop again.

wessel-novacustom avatar Mar 10 '23 08:03 wessel-novacustom

I can confirm that the keyboard is deactivated with the Dasharo Version 1.4.0 when you press the <ESC> button very early or multiple times after you turned on the laptop. Then it is impossible to navigate in the setup, in one time boot or in the Dasharo Toolsuite.

The comment of Mr. Wessel is the only possibility to get into the setup, on time boot or Dasharo toolsuite after the keyboard is deactivated.

newbieVR avatar Mar 10 '23 10:03 newbieVR

@wessel-novacustom After testing the NV41Mx and NS5x/7xMU with Dasharo firmware v1.4.0, I noticed a few cases where I couldn't get to the setup or boot menu due to the keyboard not working. There is no one specific scenario after which this happens, but I can say that it definitely occurs after turning off the device using the power button, which I described in this issue.

Pokisiekk avatar Mar 10 '23 11:03 Pokisiekk

Set of PRs fixing this on ADL laptops (to be included in v1.6.0 release for ADL):

https://github.com/Dasharo/coreboot/pull/317 https://github.com/Dasharo/edk2/pull/53 https://github.com/Dasharo/ec/pull/32

miczyg1 avatar Mar 10 '23 17:03 miczyg1

Here are the binaries in version v.1.6.0 for NS5x/7x ADL, on which the issue does not occur

Pokisiekk avatar Apr 07 '23 11:04 Pokisiekk

Unfortunately I just ran into this issue on v1.6.0. (NS5x/7xPU) Disconnecting the power supply does not fix it, and neither does disconnecting the internal battery. Special keys like turning the display on/off still work, but no sign of life from any actual keyboard inputs inside the firmware setup menu. Since this first occured, it has happened on every boot meaning that I am effectively locked out of the firmware setup.

jpnssl avatar Apr 07 '23 18:04 jpnssl

This happened after restoring default settings with F9, seems to be the same as #355.

jpnssl avatar Apr 07 '23 19:04 jpnssl

Unfortunately I just ran into this issue on v1.6.0. (NS5x/7xPU) Disconnecting the power supply does not fix it, and neither does disconnecting the internal battery. Special keys like turning the display on/off still work, but no sign of life from any actual keyboard inputs inside the firmware setup menu. Since this first occured, it has happened on every boot meaning that I am effectively locked out of the firmware setup.

@XGIVolari Thanks for reporting this. We will try to reproduce this. FWIW: it should still be possible to access the firmware settings with an external keyboard.

wessel-novacustom avatar Apr 08 '23 10:04 wessel-novacustom

@wessel-novacustom Thank you for replying to me on the weekend. External keyboards don't seem to function either. I've checked all USB ports + USB-C ones with an externally powered adapter.

Next thing I'm going to try is if reflashing the firmware helps (and if I can convince GRUB to chainload the DTS USB image)

jpnssl avatar Apr 08 '23 13:04 jpnssl

Thank you.

Next thing I'm going to try is if reflashing the firmware helps (and if I can convince GRUB to chainload the DTS USB image)

  • Yes please. I tried to reproduce the issue, but I couldn't. In DTS, when dropping a Shell (option 9) and running system76_ectool info, does it return a version info of this year; 2023? This would indicate that the EC firmware update has succeeded. Otherwise, the EC update seems to be failed.

wessel-novacustom avatar Apr 08 '23 14:04 wessel-novacustom

Reflashing the firmware image seems to have no effect. system76_ectool returns board: novacustom/ns5x_adl version: 2023-03-20_c398446 which looks sane I think. Below is the full DTS HCL report. I've also added the output from the coreboot memory console found under /sys/firmware/log as a file called firmware.log. I should also note that before restoring the settings, I had tried out both of the new ME neutering options. Maybe something went wrong there?

Notebook_NS5x_NS7xPU_Dasharo_(coreboot+UEFI)_v1.6.0_adb958f1-0783-5a2d-8e0a-4474b50d0300_2023_04_09_04_49_30_566754197.zip

jpnssl avatar Apr 09 '23 08:04 jpnssl

Update: I managed to resolve the issue by rolling EFI/EC FW back to 1.4.0 and flashing 1.6.0 again.

jpnssl avatar Apr 09 '23 11:04 jpnssl

Good to know that, thank you. I'm not sure if it's an incident or a bug. If more people have this problem, we'll investigate this.

wessel-novacustom avatar Apr 11 '23 05:04 wessel-novacustom

Restoring defaults with F9 is broken right now, so it would be best to avoid using this. It can cause a lockout and only reflashing the release image may help.

miczyg1 avatar Apr 11 '23 08:04 miczyg1

@Pokisiekk Fix for this bug for NV4x ADL has been added in firmware v1.6.0

sulewskiprzemyslaw avatar Apr 20 '23 07:04 sulewskiprzemyslaw

Hi, NS 51 TGL user here. With v1.4.0, the built-in keyboard can never be used for entering the bios F2 or the boot menu F7. An external USB keyboard does work as a work around, yet this is very annoying. @miczyg1 I see the ADL fixes are pretty old, are there TGL fixes as well?

Ferenc- avatar Oct 08 '23 14:10 Ferenc-

@Ferenc- I do not see the fix integrated into TGL build configs, so this issue is most likely still applicable for TGL devices.

miczyg1 avatar Oct 10 '23 08:10 miczyg1

I have ensured the fix will land in v1.5.0: when the PR is merged https://github.com/Dasharo/coreboot/pull/419/commits/da5e602b5cda5af4c61de87866e2918c39abcab3

miczyg1 avatar Oct 10 '23 10:10 miczyg1

I have ensured the fix will land in v1.5.0: when the PR is merged Dasharo/coreboot@da5e602

Thank you @miczyg1. Is this v1.5.0 tag in that repo, not the same v1.5.0?

Ferenc- avatar Oct 10 '23 11:10 Ferenc-

I have ensured the fix will land in v1.5.0: when the PR is merged Dasharo/coreboot@da5e602

Thank you @miczyg1. Is this v1.5.0 tag in that repo, not the same v1.5.0?

We are not yet ready to roll out the v1.5.0, so the tag may be moved...

miczyg1 avatar Oct 10 '23 12:10 miczyg1

I believe this has been solved now and should therefore be closed (?).

wessel-novacustom avatar Dec 12 '23 18:12 wessel-novacustom

@Pokisiekk This issue has been solved with the latest firmware releases, please close the issue.

wessel-novacustom avatar Apr 15 '24 14:04 wessel-novacustom