RGB.NET icon indicating copy to clipboard operation
RGB.NET copied to clipboard

Asus: Remove System.Management

Open Aytackydln opened this issue 2 years ago • 9 comments

I've had dependency problem with Aurora and my only solution was this. I know this is project specific change but I think this dependency is unnecessary anyway.

It should be removed so that it won't be problem for other projects in the future.

Aytackydln avatar Jun 14 '23 20:06 Aytackydln

what is the issue with the dependency? since this is quite a major breaking change for the provider i'd prefer to fix the actual problem.

DarthAffe avatar Jun 14 '23 22:06 DarthAffe

Error was like "Interop.AuraServiceLib.dll not found" or something. Research on internet said it was version conflict. I used various tools to figure out the conflict but none of them gave any clue. Difference between Aurora and Artemis was .net version and System.* dependencies. Removing System.Management from this library fixed my problem

Aytackydln avatar Jun 15 '23 21:06 Aytackydln

Also, these changes made sense

Aytackydln avatar Jun 15 '23 21:06 Aytackydln

This doesn't make any sense - if the error is "Interop.AuraServiceLib.dll not found" then it normally is exactly this - sometimes aura does not correctly register it in the GAC, that's why artemis is distributing it.

DarthAffe avatar Jun 15 '23 21:06 DarthAffe

I made sure to put the dll everywhere it can be found...

And this change fixes that

Aytackydln avatar Jun 15 '23 21:06 Aytackydln

yeah, but this change is also breaking device detection for some devices and i really can't see any relation between that dependency and the capability of finding a library. can you provide a full error message and stacktrace for the error?

DarthAffe avatar Jun 15 '23 21:06 DarthAffe

from looking at it i'd say you have your version conflict in aurora as you're explicitely referencing 6.0.0 of System.Management, the provider uses 7.0.0. i still don't see why that would cause in issue related to the interop lib but you'd need to generate binding redirects to fix that (or update the lib in aurora)

DarthAffe avatar Jun 15 '23 21:06 DarthAffe

Well I'm out of arguments :)

Aytackydln avatar Jun 18 '23 15:06 Aytackydln

Thank you for your fix, it fixed the issue with the asus aura devices for me too, I was having the same issue as you had :)

MesrineNathanael avatar Jun 19 '24 21:06 MesrineNathanael