darkstar icon indicating copy to clipboard operation
darkstar copied to clipboard

Fix for being able to ranged attack while resting/synthing/sitting

Open Caelic opened this issue 6 years ago • 5 comments

CanChangeState() function doesn't catch character animations such as resting/synthing/sitting for allowing or disallowing ranged attack. you are currently able to ranged attack freely while doing these 3 actions.

Caelic avatar Dec 16 '19 20:12 Caelic

is there a way to clean out those unrelated changelogs in my master branch? i don't want to fully delete it and re-fork because i have other pull requests pending off that fork right now.

only those last two commit changes apply to this pull request.

Caelic avatar Dec 16 '19 20:12 Caelic

https://help.github.com/en/github/using-git/about-git-rebase

TeoTwawki avatar Dec 16 '19 21:12 TeoTwawki

you should avoid using master for exactly this reason. Make a separate branch for each thing you are working on / pull requesting. If your server is on your fork as well, give it its own branch as well. Keep master a 1:1: copy of Darkstar's master.

TeoTwawki avatar Dec 16 '19 21:12 TeoTwawki

code itself seems fine

TeoTwawki avatar Dec 16 '19 21:12 TeoTwawki

if you need help with that rebase hit me up on discord this weekend.

TeoTwawki avatar Dec 20 '19 19:12 TeoTwawki