DarkstarProject
Trade between players can result in loss if item(s)
I have:
- [x] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
- [x] checked the commit log to see if my issue has been resolved since my server was last updated
Client Version (type /ver in game) : 30171223_0
Server Version (type !revision in game) : fae4c89
Source Branch (master/stable) : master
Additional Information (Steps to reproduce/Expected behavior) :
- Grab a buddy
- Load up your inventory so you have no slots left
- Have your buddy trade you an item.
- Note the error message "You cannot trade" due to you having no spots available for the trade
- Have your buddy trade you the same item but this time, include an item of your own in the trade window.
- Note the "trade complete" message.
- Also, note that your item was never received from your buddy and you now have 1 spot available. --the item just disappears into the nothingness never to be seen again
- Also, note the if both players inventories are completely full and a trade happens between them, only 1 of the items traded will disappear into the void.
I'm guessing on retail both parties must have enough space before the trade starts
On Feb 15, 2018 11:29 AM, "Wiggo" [email protected] wrote:
I have:
- searched existing issues (http://github.com/darkstarproject/darkstar/ issues/ https://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
- checked the commit log to see if my issue has been resolved since my server was last updated
Client Version (type /ver in game) : 30171223_0
Server Version (type !revision in game) : fae4c89 https://github.com/DarkstarProject/darkstar/commit/fae4c89592b701f76dbd48cc4b232fe57924aca7
Source Branch (master/stable) : master
Additional Information (Steps to reproduce/Expected behavior) :
- Grab a buddy
- Load up your inventory so you have no slots left
- Have your buddy trade you an item.
- Note the error message "You cannot trade" due to you having no spots available for the trade
- Have your buddy trade you the same item but this time, include an item of your own in the trade window.
- Note the "trade complete" message.
- Also, note that your item was never received from your buddy and you now have 1 spot available. --the item just disappears into the nothingness never to be seen again
- Also, note the if both players inventories are completely full and a trade happens between them, only 1 of the items traded will disappear into the void.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DarkstarProject/darkstar/issues/4563, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGI_7p_zrBjT78cU9F_1Z3cogEcIyfeks5tVHdqgaJpZM4SHTGN .
That is correct, and gil counts as an item. So, even with 1 slot (and i just did this on retail) you cannot accept an item plus gil.
Experienced this issue on Version: 30180329_1 Same steps to reproduce behavior, item lost.
so this is still a thing, just reminding.
[7:03 PM] Rheine: just traded two merman rings from one toon to another vs 3 stacks of crystals. bad trade, i know. toon to receive rings was 80/80 thats why i switched the crystals, to make room. trade completed. but the rings have disapeared. lost. just a glitch or me bad from trying that trade?
Server log shows:
[0m[01/Dec] [15:55:31][1;37m[Notice][0m [1;36mRheine->Cat trade updating trade slot id 1 with item mermans_ring, quantity 1 [0m[01/Dec] [15:55:32][1;37m[Notice][0m [1;36mRheine->Cat trade updating trade slot id 2 with item mermans_ring, quantity 1 [0m[01/Dec] [15:55:53][1;37m[Notice][0m [1;36mRheine->Cat trade updating trade slot id 1 with item mermans_ring, quantity 1 [0m[01/Dec] [15:55:54][1;37m[Notice][0m [1;36mRheine->Cat trade updating trade slot id 2 with item mermans_ring, quantity 1 [0m[01/Dec] [15:55:57][1;37m[Notice][0m [1;36mCat->Rheine trade updating trade slot id 1 with item wind_crystal, quantity 12 [0m[01/Dec] [15:55:59][1;37m[Notice][0m [1;36mCat->Rheine trade updating trade slot id 2 with item wind_crystal, quantity 12 [0m[01/Dec] [15:56:01][1;37m[Notice][0m [1;36mCat->Rheine trade updating trade slot id 3 with item wind_crystal, quantity 12
I queried inventories and verified neither player has those merman's rings.
