darkstar icon indicating copy to clipboard operation
darkstar copied to clipboard

No race/gender check

Open nasomi opened this issue 8 years ago • 20 comments

I have:

  • [ ] searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
  • [ ] checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) :

Server Version (type @revision in game) :

Source Branch (master/stable) :

Additional Information (Steps to reproduce/Expected behavior) :

Using gearsets, and I'm assuming addons, there's no server side race or gender check, so you could be a male in a opaline set, use any RSE gear you wanted, etc. This information is not even in the stock DSP database.

I have a table with all the information, and a complete fix, if anyone wants it, but I figured someone else should be aware of it.

nasomi avatar Jul 29 '17 01:07 nasomi

Does retail even have those checks? I remember this being a thing long ago where sometimes people would get a GM called on them for using RSE of a different race. So if this can be done on current retail then it's technically accurate, and warrants an option to enforce race/gender-specific gear restrictions at best.

Hozu avatar Jul 29 '17 03:07 Hozu

@Hozu I think yer right but I didn't thinka that before I sent'em to gihub. ~~I think it'd be an acceptable option at the least.~~ "If galka's cross dressing are is your thing turn this setting off."

* the current dev team dislikes settings/config options, so scratch that

TeoTwawki avatar Jul 29 '17 06:07 TeoTwawki

@nasomi not sure adding an entire new table for it is a good solution though.

TeoTwawki avatar Jul 29 '17 06:07 TeoTwawki

@Hozu You can do this on retail. If you did and the game didn't have a .dat for it you, like the case of the crossdressing Galka, it would just look like you were wearing leather armor. Same for like the Judges set on a non Hume. Using something like Wardrobe or another program or addon allows you to equip them no questions asked, as it is all client sided.

Jessland86 avatar Jul 29 '17 06:07 Jessland86

I don't know about retail, but I can't imagine an oversight like this would have lasted long. Taru's equipping galka RSE gear would make huge MP pool, same as galka equipping taru RSE would have the same effect on HP.

@TeoTwawki maybe not an entire new table, just a new column. Either way, the data is available.

nasomi avatar Jul 29 '17 12:07 nasomi

@Jessland86 Do you mean you can still do this on current retail? If so... you've got to be kidding me.

Hozu avatar Jul 29 '17 16:07 Hozu

Once I find my authenticator I'll let you know

Jessland86 avatar Jul 30 '17 01:07 Jessland86

This is not possible on retail...would be funny if it was though. capture

CTOON50 avatar Aug 01 '17 18:08 CTOON50

Try it with gearswap

On Aug 1, 2017 1:59 PM, "CTOON50" [email protected] wrote:

This is not possible on retail...would be funny if it was though. [image: capture] https://user-images.githubusercontent.com/27216726/28842010-0750c1a8-76ca-11e7-865f-5a90d0748b84.PNG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DarkstarProject/darkstar/issues/3950#issuecomment-319464740, or mute the thread https://github.com/notifications/unsubscribe-auth/AQb7PCA7oHYv45nk7srUa5v9iOYZEbuBks5sT3WrgaJpZM4OnN56 .

dwn134 avatar Aug 01 '17 19:08 dwn134

@ctoon50 it is using 3rd party tools so you cant just trust the client like dsp is which is what was being discussed

TeoTwawki avatar Aug 01 '17 19:08 TeoTwawki

Not even 3rd party programs, but gearsets, in macro's, lets you do it in DSP. Which means it lets you do it in the client. I don't know if retail lets you do it though for the client or if there's server side checks.

nasomi avatar Aug 01 '17 19:08 nasomi

retail probably moved (or will) from client side to server checks after they oticed this. I know ppl were landing in mordion over it.

last I saw they blocked it in macro etc but if you sent the right packet it still equipped

TeoTwawki avatar Aug 01 '17 19:08 TeoTwawki

I'd never heard of it until someone created a ticket for some galka wearing full taru RSE for hp++.

nasomi avatar Aug 01 '17 19:08 nasomi

I had a report about forcing gear similar but that was sounding like they meant the same piece was in all slots.. pretty sure we enforce slot typse checks and so did not think of race check thing at the time. they may have meant to tell me it was rse in all slots like that.

TeoTwawki avatar Aug 01 '17 19:08 TeoTwawki

I'll see about fixing this later tonight unless someone else want ti tackle it

TeoTwawki avatar Aug 01 '17 19:08 TeoTwawki

Just logged into retail it shows white in your inventory like you are able to equip it, but aren't able to equip them anymore. Looks like it was changed to a server side check. Using sexchange and Ashitacast I was not able to equip them either. But pretty sure AC has checks to prevent you doing this anyway. As a side effect you cannot use your client to directly equip your actual races RSE, but you can using Ashitacast. Assuming the same for Windower and Gearswap. Char is normally a Hume Female btw not a taru. untitled

Jessland86 avatar Aug 01 '17 20:08 Jessland86

@jessland86 thanks for the verification

TeoTwawki avatar Aug 01 '17 20:08 TeoTwawki

Just checked with GearSwap, it does not equip it in retail.

CTOON50 avatar Aug 01 '17 21:08 CTOON50

So they did fix it. Not surprising at all. Guess all that's needed in the DB is a bitmask for each equip for (in)eligible races, and then a check in the core, wherever that would be.

Hozu avatar Aug 02 '17 00:08 Hozu

I I have the bitmask and the code to fix it.

nasomi avatar Aug 02 '17 00:08 nasomi