SPToCore icon indicating copy to clipboard operation
SPToCore copied to clipboard

Type TEXT and FLOAT support

Open marturojt opened this issue 4 years ago • 1 comments

hi @DarioN1 ,

My team has been using your amazing tool and we are so greatfull with the results. While we used it, one of my teammates realices that the tool throws and error with stored procedures that has type text or float columns, so we add these lines to the "Program.cs" inside the static string called SP_GetType:

else if (type == "text")
                return "string";

and

else if (type.Contains("float"))
                return "decimal" + (isNullable ? "?" : "");

We also add these inside the static string SP_GetDBType:

else if (type == "text")
                return "string";

We really hope that you could include these lines at your source code.

Regards and keep coding =)

marturojt avatar Apr 24 '21 03:04 marturojt

Hi Arturo and Thanks for the help ! I will include your changes as soon as possible 😉 Thanks for your contribute. I'm glad to know that you and your team are using it... See you !


From: Arturo Jimenez @.> Sent: Saturday, April 24, 2021 5:58 AM To: DarioN1/SPToCore @.> Cc: Dario Tordin @.>; Mention @.> Subject: [DarioN1/SPToCore] Type TEXT and FLOAT support (#17)

hi @DarioN1https://github.com/DarioN1 ,

My team has been using your amazing tool and we are so greatfull with the results. While we used it, one of my teammates realices that the tool throws and error with stored procedures that has type text or float columns, so we add these lines to the "Program.cs" inside the static string called SP_GetType:

else if (type == "text") return "string";

and

else if (type.Contains("float")) return "decimal" + (isNullable ? "?" : "");

We also add these inside the static string SP_GetDBType:

else if (type == "text") return "string";

We really hope that you could include these lines at your source code.

Regards and keep coding =)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/DarioN1/SPToCore/issues/17, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEL6KIEFL6TCC42YAWO6ZODTKI6XBANCNFSM43PWRTVA.

DarioN1 avatar Apr 25 '21 08:04 DarioN1