Dante Soares

Results 82 comments of Dante Soares

The monkeypatch seems to have fixed the signature issues that we had. I'll make a PR.

I think it's up to y'all but whichever one you use, I'd say it would be better to be consistent and use the same one everywhere.

It's in the initializer. The default is here: https://github.com/lml/commontator/blob/856ff205ffbbb0c32aab39afe5fce3da958c650f/config/initializers/commontator.rb#L100-L102 If you use a different column, simply change the block accordingly.

This may be due to changes in how Rails loads files. Try requiring the copied files?

My guess is these workarounds are needed mainly because active_storage doesn't follow normal Rails/railties engine conventions. Normal engines do something like this: ``` # config/routes.rb GemName::Engine.routes.draw do # some routes...

There's a lot here, so I can't be sure you did everything but once you do what I suggested you should be ready to merge.

@jpslav Should be good but once again I suggest not merging schema.rb if you can.

Adding commontator to Quadbase would require many changes, including getting rid of this. However, I didn't plan on doing that for now. I would have to update commontator to add...

I thought the only way to delete a draft was to remove it from all projects (that is, deleting all question collaborators)?

Oh I see what you mean. In question.rb, change: ``` ruby has_many :collaborators, :through => :question_collaborators, :source => :user ``` to ``` ruby has_many :collaborators, :through => :question_collaborators, :source =>...