Daniel
Daniel
the changed logging shall use https://github.com/Ericsson/ecchronos/blob/master/core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/utils/logging/ThrottlingLogger.java
Looks good to me but someone else has to approve it
Now all comments should have been handled
To quote macan when I asked for a Definition of Done for this task. "DoD är, flytta alla debug loggar som inte hjälper med troubleshooting till trace." This is just...
Are these a good starting point? https://www.javatpoint.com/log4j-logging-levels
gone through the codebase and there are these number of log entries debug: 47 error: 52 info: 17 (seems low according to the definition above) trace: 18 warn: 42 [log.debug.txt](https://github.com/Ericsson/ecchronos/files/15452071/log.debug.txt)...
The log level definitions suggested by Johan seems ok to me
Looking at the code in some places LOG.is..Enabled are used and in some places it is not. I assume we want it to be used everywhere for trace, debug, info...
if there are no complaints on the descriptions on the log levels before the end of this week the current ones wll be used/kept
Or should the guideline in CONTRIBUTION.md be that if building the log message requires calculations or collecting data the is....Enabled should be used.