zipkin-javascript-opentracing icon indicating copy to clipboard operation
zipkin-javascript-opentracing copied to clipboard
verified publisher icon DanielMSchmidt

Support for the method `Span.addTags`

Open bedorlan opened this issue 7 years ago • 1 comments

The method Span.addTags is not supported.

Its documented here: https://opentracing-javascript.surge.sh/classes/span.html#addtags

bedorlan avatar May 15 '18 19:05 bedorlan

AFAIK Zipkin only provides one interface for span annotations, we need to use that I would guess. We currently implement log, so we could write it like this:

addTags(tags) {
	this.log(tags);
}

How would you feel about doing this change?

DanielMSchmidt avatar May 16 '18 06:05 DanielMSchmidt