Dan Cech

Results 51 comments of Dan Cech

Alternatively the dependency could be specified as `^0.14.0 || ^15.0.0` or `0.14.x || 15.x.x` to maintain backward compatibility.

There is a PR https://github.com/intelsdi-x/snap-plugin-lib-go/pull/89

> does this mean we can get rid of the second wire dependency graph? Right now I haven't changed anything related to wire, will need more investigation. > > but...

The latest commit explores how we could move to a single `grafana` binary and just keep grafana-cli and grafana-server as BC helpers. It's implemented by converting both grafanacli and grafana-server...

We have not tested this kind of scenario, but you may be able to make it work by first setting it up as a direct connection, then editing the config...

There are a few different concerns here, firstly with the current code an ipv6 address wrapped in square brackets will fail because net.ParseIP will fail and return nil in that...

@yincongcyincong it looks like your earlier commits have an email address that doesn't match your github account, which is causing the CLA bot to reject the PR. I think you...

This got a bit more involved with the changes to support using NamespacedID and handling Namespace properly, I ended up changing that from a raw string to a proper type...

Not going to merge this on a Friday afternoon, but feel free to merge it any time. I'll merge on Monday if you don't get to it before I do.

We need to think about the semantics of this system and how it will work in a k8s world, we don't want to introduce behavior now that we're going to...