Minimum note duration

[SolfaMode]

The miminum note duration setting might not work as expected. Problem may the following line in BasicPitch::setParameters. mParams.minNoteLength = static_cast(std::round(inMinNoteDurationMs * FFT_HOP / BASIC_PITCH_SAMPLE_RATE)); From how it is used in Notes.cpp minNoteLength is the number of frames in the posteriograms. In BasicPitch training there are 172.0 * 22050.0 / 43844.0 posteriogram frames per second. So line should be instead: mParams.minNoteLength = static_cast(std::round(params.minNoteDurationMs / 1000.0 * 172.0 * 22050.0 / 43844.0));