client icon indicating copy to clipboard operation
client copied to clipboard

Added get_predictions on QueryResult

Open jinensetpal opened this issue 1 year ago • 5 comments

Created a get_predictions function that:

  1. Loads a model registered with DagsHub-hosted MLFlow
  2. Locally performs inference on it and either appends to a column, and/or returns it for further use.

jinensetpal avatar Jul 01 '24 12:07 jinensetpal

Can you redo the linter/long-lines commits with line length set to 120, please? Too many changes, which tells me that it was probably done with 80.

What are you using to format? If it's black, rerun it with --line-length 120 (AFTER you roll back the commits)

I hope to move to pyproject.toml one day so I can keep this consistent :)

kbolashev avatar Jul 01 '24 12:07 kbolashev

On it!

jinensetpal avatar Jul 01 '24 13:07 jinensetpal

Interesting note, black does not format comments if they are over the length limit, but flake8 raises issues. What's the preferred approach?

jinensetpal avatar Jul 01 '24 13:07 jinensetpal

Interesting note, black does not format comments if they are over the length limit, but flake8 raises issues. What's the preferred approach?

I just line break them manually, so it makes sense logically. I switched from black+flake8 to ruff recently, it's a lot faster so I usually get complaints about long line lengths immediately. But it also doesn't break comments

kbolashev avatar Jul 01 '24 13:07 kbolashev

Thank you for being so thorough!

jinensetpal avatar Jul 08 '24 04:07 jinensetpal

Closing as this is part of https://github.com/DagsHub/client/pull/513

kbolashev avatar Sep 04 '24 09:09 kbolashev