Daemon Use pkg-config for curses

This reportedly fixes a compilation error on Gentoo, similar to https://github.com/jonathanklee/ngp/issues/30.

Jan 25 '23 20:01 necessarily-equal

Does this have implications on other platforms? Can we do find_package first and then pkg-config after?

Jan 25 '23 20:01 DolceTriade

pkg-config is love, pkg-config is life.

I don't know the implications for other platforms, but at least it seems CI works.

I know we rely on pkg-config for Unvanquished by the way.

On Wed, Jan 25 2023 at 12:59:50 -08:00:00, DolceTriade @.***> wrote:

Does this have implications on other platforms? Can we do find_package first and then pkg-config after?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

Jan 25 '23 21:01 necessarily-equal

Honestly I thought find_package was calling pkg-config under the hood.

Jan 25 '23 21:01 DolceTriade

It surely breaks Windows. The CI image just has a ton of crap preinstalled on it.

Jan 26 '23 02:01 slipher

Windows is defined here: https://github.com/DaemonEngine/Daemon/pull/785/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR636 (earlier, line 636), so isn't affected by this

Jan 26 '23 06:01 necessarily-equal

You still need to guard find_package(PkgConfig) though

Jan 26 '23 15:01 slipher