Daemon icon indicating copy to clipboard operation
Daemon copied to clipboard

Daemon-vulkan infrastructure 2

Open VReaperV opened this issue 5 months ago • 7 comments

Adds some more cmake changes required for daemon-vulkan, slightly modified version of the Khronos Vulkan header generator, as well as a shader generator with support for #insert/#include and SPIR-V generation. Also added some of the embed stuff from #1842 with more functionality.

VReaperV avatar Oct 05 '25 00:10 VReaperV

Most of the changes are just the XML spec and existing generator code.

VReaperV avatar Oct 05 '25 00:10 VReaperV

VulkanHeaders seems to be a third-party library, so it should go in libs. Is there some good reason to check in the files directly instead of using a submodule?

Most of it is not used by daemon-vulkan.

VReaperV avatar Oct 05 '25 00:10 VReaperV

So what is the future maintenance plan for VulkanHeaders: do we expect to maintain it ourselves or periodically sync updates from upstream?

slipher avatar Oct 05 '25 00:10 slipher

So what is the future maintenance plan for VulkanHeaders: do we expect to maintain it ourselves or periodically sync updates from upstream?

Periodic sync. Header generator rarely ever gets updates and likely would continue working as is without issue.

VReaperV avatar Oct 05 '25 00:10 VReaperV

OK cool. In any case it should go in libs/

slipher avatar Oct 05 '25 01:10 slipher

Moved it.

VReaperV avatar Oct 05 '25 01:10 VReaperV

slightly modified version of the Khronos Vulkan header generator,

If there are modifications of the files in libs/ relative to upstream, would you mind checking in the original upstream version as the first commit, and then the local changes as a second commit? That way we can see what was changed in the history.

Also I request that the commit hash of the Vulkan Headers repo be recorded in the commit message.

Sure, done.

VReaperV avatar Oct 05 '25 12:10 VReaperV