Daemon icon indicating copy to clipboard operation
Daemon copied to clipboard

renderer: fix legacy dynamic light intensity

Open illwieckz opened this issue 1 year ago • 1 comments

When I fixed the legacy dynamic light renderer in #1093, I noticed the dynamic light was too faint.

Since then I noticed the light was brighter with such renderer when legacy map overbright was enforced, meaning it was the overbright cancellation that was running where it should not.

This is now fixed.

Legacy dynamic light renderer with legacy overbright (reference):

unvanquished_2024-05-13_131200_000

Legacy dynamic light renderer with new overbright implementation:

unvanquished_2024-05-13_133738_000

For comparison, this is how it looks with the non-legacy tiled dynamic light renderer:

unvanquished_2024-05-13_131510_000

The light is believed to be different because the lighting algorithm is totally different to begin with.

The legacy light renderer not saturating to white is believed to be because the legacy dynamic light blends the dynamic light as a separate stage and then, the light is clamped, we can't fix that easily, it's a legacy renderer anyway.

illwieckz avatar May 13 '24 11:05 illwieckz

LGTM (didn't really review or test)

slipher avatar May 25 '24 02:05 slipher