Daemon icon indicating copy to clipboard operation
Daemon copied to clipboard

Allow keyboard input to UI and binds simultaneously

Open slipher opened this issue 2 years ago • 1 comments

Stacked on #1029. Please review that one first.

Gamelogic companion: https://github.com/Unvanquished/Unvanquished/pull/2900

The cgame can now, if it wishes, receive key up and key down events while binds are active. Upon receiving a key down event, the cgame will return a boolean indicating whether the keystroke was consumed by the cgame. If the keystroke was consumed by the cgame, no binds will be executed.

Requires breaking ABI changes to the key event and key catcher interfaces.

slipher avatar Jan 15 '24 07:01 slipher

tested it and seemed ok to me.

DolceTriade avatar Jan 23 '24 08:01 DolceTriade

https://github.com/Unvanquished/Unvanquished/pull/2900 was approved so now I just need an LGTM on this one.

slipher avatar Apr 03 '24 00:04 slipher

Lgtm

DolceTriade avatar Apr 13 '24 05:04 DolceTriade