FeatureFlagsBundle icon indicating copy to clipboard operation
FeatureFlagsBundle copied to clipboard

Percentage toggle condition improvement

Open hamaryuginh opened this issue 8 years ago • 2 comments

In case of multiple call to isActive() on a flag having percentage condition, there is multiple call to setcookie function, which can cause error because of too big response header (each Set-Cookie: ... will be in the response header).

To avoid this, you can, for example, add something like this: $this->request->cookies->set($config['cookie'], $value); after setcookie() function... Not very beautiful, but it works ;-)

Thx.

hamaryuginh avatar Feb 15 '17 20:02 hamaryuginh

Hey,

thanks for you comment. I will have a look at it. Had never seen it is failing but you might be right. Do you need an improvement in a short time? Only for personal prioritizing 😉

Greets

DZunke avatar Feb 16 '17 11:02 DZunke

Hello,

I don't need an improvement in short time, I created a custom Percentage condition meanwhile...

Thank you.

hamaryuginh avatar Feb 16 '17 11:02 hamaryuginh