dspace-angular icon indicating copy to clipboard operation
dspace-angular copied to clipboard

Export/import options missing from admin menu after shibboleth login

Open mspalti opened this issue 3 years ago • 15 comments

Describe the bug The admin menu is shown after logging via Shibboleth as an administrator (fixed by https://github.com/DSpace/dspace-angular/pull/1805) However, the export and import options are missing from the menu. To see these options, you need to reload the page.

To Reproduce Steps to reproduce the behavior:

  1. Login via shibboleth as admin
  2. Export / Import options will be missing
  3. Reload the page and the options appear

Related work https://github.com/DSpace/dspace-angular/pull/1805

mspalti avatar Nov 04 '22 21:11 mspalti

@ybnd : Wanted to ping you on this as this bug seems to be a follow-up to #1805, which you fixed. If it's something you are interested in, let me know. It'd obviously be nice to get this menu working properly for Shibboleth auth.

tdonohue avatar Dec 13 '22 15:12 tdonohue

Should be retested in 7.6. Is it possible that https://github.com/DSpace/dspace-angular/pull/2187 could have fixed this (or improved it?).

tdonohue avatar Jun 29 '23 20:06 tdonohue

This seems to be working on our site now. I'm not running 7.6 yet, but the #2187 fix is applied to our site so that might have fixed it.

mspalti avatar Jun 29 '23 23:06 mspalti

Thanks for the verification @mspalti ... I suspected this error was a side effect of the larger problem fixed by #2187.

In that case, I'm going to close this as "fixed" in 7.6. If we find it's not fully resolved we can always reopen it later on.

tdonohue avatar Jun 30 '23 14:06 tdonohue

I just want to note that in our development server, this is still happening after the upgrade to 7.6.1. All other menu options show on first Shibboleth login, but Import and Export menus do not show until a manual page refresh.

I will update once we move 7.6.1 to production in the next week or so, but our dev environment is very close to our production one so I don't expect a difference.

pybrarian avatar Jan 30 '24 22:01 pybrarian

Chiming in here to say that like @pybrarian this is still a problem for one of our administrator users after they log in with Shibboleth. We're on version 7.6.1. The import/export menu options don't appear after they log in until they refresh or click around on the page at least once. I'm going to video chat with them to see if there's any information in the browser's dev tools.

nwoodward avatar Feb 15 '24 17:02 nwoodward

Reopening as it seems this may not be solved completely by #2187. Moving it back to the 7.6.x project, but it is waiting on a volunteer.

tdonohue avatar Feb 15 '24 17:02 tdonohue

We see the same problem. I think it stopped working in 7.6.1, for reasons possibly related to #2669. A fix for that issue is in 7.6.2 but I haven't tested to see if it also resolves the menu issues.

mspalti avatar Feb 16 '24 18:02 mspalti

Could someone watching this ticket test to see if #2670 fixes this bug? That's the code that was added to (unreleased) 7.6.2 in order to fix #2669. If that solves the problem, then this ticket would be essentially a "duplicate" of #2669 & can be closed again.

tdonohue avatar Feb 16 '24 19:02 tdonohue

Could someone watching this ticket test to see if #2670 fixes this bug? That's the code that was added to (unreleased) 7.6.2 in order to fix #2669. If that solves the problem, then this ticket would be essentially a "duplicate" of #2669 & can be closed again.

Running 7.6.1 with this patch in our test environment – it fixed #2669 but not this issue (#1953).

abbydrury avatar Feb 23 '24 18:02 abbydrury

Same here. I pulled #2670 into the codebase, but this problem persists.

nwoodward avatar Feb 27 '24 21:02 nwoodward

This has become a showstopper for us, and I'm trying to figure out if 1) we need to revert back to 7.6, 2) there's a workaround, 3) there's a particular commit that I can revert for now, or 4) anyone has any ideas about where the problem is. I'm willing to attempt a solution, but a clue or two would help.

It's to the point for some Shibboleth users where no amount of refreshing or clicking around brings the import/export menus back.

nwoodward avatar Mar 06 '24 18:03 nwoodward

@nwoodward : It's unclear to me where the issue resides and how it began again between 7.6 and 7.6.1. So, I don't have any great advice right now. This really needs closer analysis & I've had difficulty finding anyone willing to volunteer.

My only recommendation would be to first test with latest dspace-7_x branch to see if it's somehow magically "fixed" in pre-7.6.2. If not (and it likely isn't), then perhaps a "clue" would be to see if you can determine what may have broken it between 7.6 and 7.6.1. I wish I had better advice. But, maybe someone else will chime in with additional clues.

tdonohue avatar Mar 06 '24 19:03 tdonohue

Hi @tdonohue. Thanks for the information. I'll look around at the commit history.

nwoodward avatar Mar 11 '24 17:03 nwoodward

@tdonohue on a side note, I tried to set up a Shibboleth test environment using the docker image. But it looks like https://samltest.id/ is no longer available. I tried a two other potential test Idp services but I wasn't able to get either of them working.

mspalti avatar Mar 12 '24 23:03 mspalti