docling icon indicating copy to clipboard operation
docling copied to clipboard

feat: Allowing EasyOCR to use the recog_network parameter

Open itsainii opened this issue 1 year ago • 4 comments

Adding recog_network parameter of EasyOCR to allow users use their own custom recognition model.

Issue resolved by this Pull Request: Resolves #602

Checklist:

  • [ ] Documentation has been updated, if necessary.
  • [ ] Examples have been added, if necessary.
  • [ ] Tests have been added, if necessary.

itsainii avatar Dec 16 '24 08:12 itsainii

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • [X] title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

mergify[bot] avatar Dec 16 '24 08:12 mergify[bot]

Thanks for the PR. For letting the test pass, you have to apply the pre-commit hooks, see CONTRIBUTING.md

pre-commit run --all-files

dolfim-ibm avatar Dec 16 '24 08:12 dolfim-ibm

Thanks for the PR. For letting the test pass, you have to apply the pre-commit hooks, see CONTRIBUTING.md

pre-commit run --all-files

I made the changes by editing the file directly in the fork on GitHub. Do I need to run the command locally, or is there a way to handle this directly on GitHub?

itsainii avatar Dec 16 '24 09:12 itsainii

I made the changes by editing the file directly in the fork on GitHub. Do I need to run the command locally, or is there a way to handle this directly on GitHub?

Well, the command above will auto-update all the files to fit the styling. You can also try to fix it in the online editor (I think it is only the single vs double quotes.

dolfim-ibm avatar Dec 16 '24 09:12 dolfim-ibm

Superseded by https://github.com/DS4SD/docling/pull/613

dolfim-ibm avatar Dec 17 '24 08:12 dolfim-ibm