TWiLightMenu icon indicating copy to clipboard operation
TWiLightMenu copied to clipboard

Warn user when saving cheats with an E-type code enabled

Open spellboundtriangle opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe. nds-bootstrap currently does not handle E-type cheat codes correctly, so they may not work when applied.

Describe the solution you'd like Notify the user when saving cheats that include an E-type cheat that some of the selected cheats may not work correctly. It would read something like this:

Some of the enabled cheats may not function correctly:

- Unlock All Worlds



[A] Dismiss   [Y] Disable   [B] Cancel

Describe alternatives you've considered Some way of doing this within the cheats menu itself would also work, but that may introduce more convolution than necessary.

Additional context None

spellboundtriangle avatar Mar 02 '22 20:03 spellboundtriangle

I tried this in the past, #1299, and the warning worked fine but I wasn't sure how exactly to detect an E type code, or at least an E type code likely to not work.

The warning in the PR was frequently triggering on codes that worked fine.

Epicpkmn11 avatar Mar 10 '22 00:03 Epicpkmn11