dnn-elements icon indicating copy to clipboard operation
dnn-elements copied to clipboard

Tabs - rename the "visible" properties to "active"

Open X3Technology opened this issue 3 years ago • 4 comments

"active" is more accurate (and consistent with the help text). All the tabs are "visible".

X3Technology avatar Apr 18 '22 20:04 X3Technology

Are you talking about the CSS variable names? If so, I tend to agree.

david-poindexter avatar Apr 18 '22 20:04 david-poindexter

I am not disagreeing but be aware that this would be a breaking change for consumers, we are still in v0.x.x phase so it is technically possible but the project is already being used in multiple modules... Just if a PR comes in to change it, we need to call attention to it in the release notes.

valadas avatar Apr 18 '22 21:04 valadas

IMHO, people using a v0 product should expect breaking changes. Better to fix it now than when it has wide spread adoption.

X3Technology avatar Apr 18 '22 22:04 X3Technology

I don't think anyone is refuting that @X3Technology. We just need to treat it semantically as a breaking change (because it is) and call attention to it in the release notes so that developers that are consuming these can update accordingly.

These components have been in use in production extensions for a long time now. So, even though it is pre-v1 and many people are just now taking notice of the project, it has actually been in existence for almost three years now. :)

david-poindexter avatar Apr 18 '22 23:04 david-poindexter