libspdm

libspdm copied to clipboard

Signed-off-by: Steven Bellock

steven-bellock

libspdm requires `OpaqueDataFmt1` to be selected during `NEGOTIATE_ALGORITHMS`. See : https://github.com/DMTF/libspdm/blob/21729b5456e7075a23ca8918d0b12b3a4a0eac43/library/spdm_requester_lib/libspdm_req_negotiate_algorithms.c#L476-L481 However it should be legal to have no `OpaqueData`. From the specification >If the Requester or the Responder does...

steven-bellock

Fix : #1360 Signed-off-by: Xiaohanjlll

Xiaohanjlll

Add raw key support in spdm_device_secret_lib_sample

1

Fix: #1356 Signed-off-by: Wenxing Hou

Wenxing-hou

Fix: #1354 Signed-off-by: Wenxing Hou

Wenxing-hou

Error message when receiving Challenge via secure session

9

Hi all, The Spec. says transmitting Challenge via session is prohibited. (outside of a session is allowed.) What is the error response type when the responder receives Challenge message under...

KwonHyunSoo

And consider refactoring `libspdm_bin_concat()` so that it uses a generic label like `SPDM_VERSION_GENERIC_BIN_CONCAT_LABEL "spdmx.x "` since the version numbers are overwritten in the function. At first glance it looks like...

steven-bellock

Improve VCA request / response validation

3

Examples include: - Validate that one-hot fields are actually one-hot. - In negotiate_algorithms the requester loops over ALGORITHMS.param1 without validating it first.

steven-bellock

Unable to build when code coverage is enabled

4

See https://github.com/DMTF/libspdm/actions/runs/3372264103/jobs/5595487418#step:3:414 This is with `cmake -DARCH=x64 -DTOOLCHAIN=GCC -DTARGET=Debug -DCRYPTO=mbedtls -DGCOV=ON ..`

steven-bellock

Enable GCOV=ON in CI/CD

2

In https://github.com/DMTF/libspdm/blob/main/.github/workflows/build.yml have at least one build configuration where GCOV is enabled. Probably `-DARCH=x64 -DTOOLCHAIN=GCC -DTARGET=Debug -DGCOV=ON ..`

steven-bellock