roadmap
roadmap copied to clipboard
Prevent '%{org_title} Plans' Section From Displaying Plans Created by Users From Other Organisations
Fixes #3345 Fixes #3414
Changes proposed in this PR:
-
app/controllers/application_controller.rb- Add pdf handling in
render_respond_to_format_with_error_message-
render_respond_to_format_with_error_messageis called both when rescuing from Pundit::NotAuthorizedError and ActiveRecord::RecordNotFound. The method works properly with .html format, but prior to this change, ActionController::UnknownFormat was thrown for .pdf format.
-
- Add pdf handling in
-
Edit
scope :organisationally_or_publicly_visible- Within this scope, replace
Org.org_admin_planswith newly createdOrg.owned_plans.-
Org.org_admin_planswould return any plan whereplan.org_id = Org.id. In addition, it would return any plan where a user with user.org_id = Org.id had Administrator access on the plan. -
Org.owned_plansonly returns plans where the Creator access for the plan belongs to a user with user.org_id = Org.id
-
- Within this scope, replace
| 1 Error | |
|---|---|
| :no_entry_sign: | Please include a CHANGELOG entry. |
Generated by :no_entry_sign: Danger
Closing this for now. More discussion is needed on how to resolve issue #3345.