roadmap
roadmap copied to clipboard
Missing Assignment Operator For do_not_reply_email
Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
- v4.1.1
config/initializers/_dmproadmap.rb includes the following line:
# This email is used as the 'from' address for the feedback_complete email to users
config.x.organisation.do_not_reply_email 'do-not-reply@cc_curation_centre.org'
It appears that the only time that the do_not_reply_email is used, is when sending e-mails after a feedback request is completed (Note: the assignment to sender prevents the nil do_not_reply_email value from being an issue:
I18n.with_locale I18n.default_locale do
sender = Rails.configuration.x.organisation.do_not_reply_email ||
Rails.configuration.x.organisation.email
mail(to: recipient.email,
from: sender,
subject: format(_('%{tool_name}: Expert feedback has been provided for %{plan_title}'),
tool_name: tool_name, plan_title: @plan.title))
end
The behaviour of the app will have to be tested after the missing = is added in _dmproadmap.rb.