MAX_NUMBER_GUIDANCE_SELECTIONS value hardcoded in views/plans/_guidance_selection.html.erb

[StCyr]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

4.1.0

Expected behaviour:

"6" should not be hardcoded

Actual behaviour:

legend><%= _('Select up to 6 organisations to see their guidance.') %></legend>

[StCyr]

I'm not sure how to best solve it: MAX_NUMBER_GUIDANCE_SELECTIONS is defined in app/views/layouts/application.html.erb and thus seems only accessible via javascript

So a solution might be to update this value at run time via a javascript with $( document ).ready() but it looks a bit wacky to me. A better solution is probably to define a new configuration setting in config/initializers/_dmproadmap.rb and use this configuration settings' value in views/plans/_guidance_selection.html.erb (and app/views/layouts/application.html.erb)

What do you think?

[nicolasfranck]

Maybe there is good reason for this maximum value? It would make the list of guidances long if not managed well, but I am not sure if that should be a software concern? So one could also choose to remove this altogether?