Plan.visibility_allowed? method unclear

[nicolasfranck]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

3.1.1

Behaviour:

The current body of method Plan.visibility_allowed? suggests that the visibility of the entire plan can be changed if at least one of the phases allows it (see Phase.visibility_allowed?(plan))

But Phase.visibility_allowed?(plan) calculates the percentage over all answers, i.e. for all phases instead of one. So that could be moved to model Plan. Unless of course that was not meant to be there?

Anyway, it seems strange that the answers from all the phases are taken into account. I know, visibility is actually an attribute on the whole Plan ;-)