t8code icon indicating copy to clipboard operation
t8code copied to clipboard

Package released versions of `p4est`/`sc` with t8code

Open sloede opened this issue 2 years ago • 3 comments

Right now, t8code comes packaged with its "own" versions of p4est and sc, and the exact version that is installed if no external libraries are specified using --with-sc or --with-p4est depends on the commit hash used for the respective git submodule.

From a user perspective, it would be much more convenient if instead of some version off the upstream repositories, t8code releases were packaged with actual releases of p4est and sc. That way, one could easily decide which version of t8code is known to work with which version of, e.g., p4est, by checking which version was packaged with the respective t8code release.

This is just a proposal of course, but maybe it will help others to make sure that t8code and p4est interop is more stable if, e.g., a program links to both libraries simultaneously.

sloede avatar Apr 27 '23 14:04 sloede

I agree. We usually make this work with every x.y.z release. Only intermediate development stages use hashes in the CI.

cburstedde avatar Apr 27 '23 14:04 cburstedde

In p4est and sc, releases are identified by the tags of the form vx.y.z. We do not always produce the tarballs, but should.

cburstedde avatar Apr 27 '23 14:04 cburstedde

I agree. We'll consider this in future releases.

jmark avatar Apr 28 '23 09:04 jmark