AMP icon indicating copy to clipboard operation
AMP copied to clipboard

Steam Login popup doesn't appear if no user is logged on at the time

Open GGServersDevelopment opened this issue 2 years ago • 3 comments

Bug Report

System Information

  • Operating System (Including distribution name and version number) Debian 11
  • AMP version and build date (Always use the version number, 'latest' is not valid!) v2.4.2, built 21/02/2023 11:49
  • Which AMP release stream you're using (Mainline, Nightly or FastTrack) Mainline

I confirm:

  • [x] that I have searched for an existing bug report for this issue.
  • [x] that I am using the latest available version of AMP.
  • [x] that my operating system is up-to-date.
  • [x] that my checkboxes above look exactly like the one on the left with no extra spaces. Remove this line to confirm you can follow instructions - if this line shows up in the bug report then the whole report will be ignored

Symptoms

When deploying a steam-login requiring instance that auto-updates on startup, the pop up for the Steam Login only appears for users currently logged into the panel. If the user is not logged in, the pop up will never appear and it will not be at all obvious what the issue is.

Mention: I am not sure if related or a separate issue, but I wanted to mention that clicking abort and kill does not work in this situation.

Reproduction

  • Create an Arma 3 server with the setting to auto update on startup
  • Manage the Arma 3 server or login to it via its own panel
  • The panel will show "Application State: Installing components", and the logs will show a user action is required, but no pop up appears for the user to login
  • Clicking abort does not actually abort the task, though I am not sure if related or a separate issue
  • Clicking kill does not actually kill the task, also not sure if related

GGServersDevelopment avatar Feb 27 '23 17:02 GGServersDevelopment

This was also found to require a complete instance restart as you can't kill the task. Assigning to 2.4 LTS for visibility.

southnode avatar Apr 15 '23 11:04 southnode

There should be a check on generic instances if the login method is anonymous. And if not, the scheduled task should not be an option. Otherwise, AMP needs a way to securely store login details for Steam (preferred).

IceOfWraith avatar Apr 15 '23 14:04 IceOfWraith

What I might do is add hidden settings for remembered SteamCMD login details and add a checkbox there rather than settings that can be populated.

What I don't want to happen is hosts try and pre-populate a set of Steam login details as that's a TOS violation.

For now I've avoided this problem by adding a timeout to the Steam Guard prompt so it won't lock AMP up.

PhonicUK avatar Apr 22 '23 10:04 PhonicUK