crowd.dev icon indicating copy to clipboard operation
crowd.dev copied to clipboard

[C-1048] Members: Search members with associated email

Open tchiotludo opened this issue 3 years ago • 13 comments

What problem are you trying to solve?

I want to be able to find all members that have at least one email.

The same than identities for email: image

I also need to be able to search for a substring on the email (mostly the domain name of the email)

What's your suggested solution?

No response

Examples (if relevant)

No response

Is anything blocking this from being implemented? (if relevant)

No response

Definition of Done

No response

C-1048

tchiotludo avatar Mar 30 '23 11:03 tchiotludo

Thanks for that input. And yes, I agree that we should have this filter capability.

We will see if we can prioritize it.

jonathimer avatar Mar 30 '23 11:03 jonathimer

@jonathimer, @joanreyero i can work on this one. just a small doubt how it should look in the UI, just like filters options drop down should have an email option and then clicking on it opens a search bar to filter out on basis of emails sub string user enters?

agentraghav avatar May 17 '23 16:05 agentraghav

Awesome! Looping in @nunoeufrasio who is the product designer for this product

I think we should simply add a string search filter called "Emails". Additionally, we could add Email as option to the multi-select filter "Identities". This would allow users to filter by all members that have an email associated to their profile.

jonathimer avatar May 17 '23 19:05 jonathimer

Agree with @jonathimer on adding email to identities filter, in fact we treat it as an identity.

As per searching for email (substrings), I would simply allow users to query them via the search bar…we already let users find members typing the full email/string.

We can tweak the search bar placeholder so its clear ⬇️ Screenshot 2023-05-19 at 04 46 36

nunoeufrasio avatar May 19 '23 10:05 nunoeufrasio

Hey 👋 Sorry for the late reply @agentraghav! Just checked with @anilb0stanci and at the moment backend does not support this issue's requirements. To be able to search for an email without a full match and include email in the Identities filter, this issue must be addressed first

joanagmaia avatar Jun 06 '23 17:06 joanagmaia

any update on a release date? I've some members on slack that changed their nickname, without email search I could find them on crowd.dev because :

  • the new nickname is not indexed on crowd.dev
  • email is not searchable (the only link I could have on this kind of members)

THanks

tchiotludo avatar Jul 04 '23 15:07 tchiotludo

Hey @tchiotludo! The issue is currently being tackled internally. ETA is 1-2 weeks.

jonathimer avatar Jul 06 '23 07:07 jonathimer

@jonathimer @yeganathan18 is this still internally implemented? I can see that the BE ticket @joanagmaia mentioned has been merged

peoray avatar Sep 06 '23 12:09 peoray

@yeganathan18 @joanagmaia, any update on this :)

peoray avatar Sep 11 '23 08:09 peoray

Hey @peoray it's partially done. So we are now able to search by email in the search bar, but as mentioned in the issue description, it would also be needed to add the Email option to the Identities filter, so that user is able to filter members that have at least one email

joanagmaia avatar Sep 11 '23 17:09 joanagmaia

@joanagmaia Identities filer option is coming from the integration. Email is not an integration, any clue how to add it such that the query would be successful? I added it manually to the array but that did not work

peoray avatar Sep 12 '23 14:09 peoray

Hey @peoray, sorry I missed this! You are very right, emails work differently from other identities. So in frontend/src/modules/member/config/filters/identities/config.ts you will need to refactor apiFilterRenderer so that email is treated differently. For email specifically, we will probably want something like

email: {
   ne: null
}

Let me know if this helps

joanagmaia avatar Sep 21 '23 09:09 joanagmaia

@joanagmaia how can I make sure Email is added as one of the select options? I'm getting an unknown field operator error Unknown field or operator: email!

The PR has been updated to reflect the new changes

peoray avatar Sep 26 '23 12:09 peoray