crowd.dev icon indicating copy to clipboard operation
crowd.dev copied to clipboard

Add email option to members identities filter list

Open peoray opened this issue 2 years ago • 11 comments

Changes proposed ✍️

What

Fixes #703

🤖 Generated by Copilot at 57c829d

This pull request adds email filtering and searching to the member module in the frontend. It updates the identities filter config and the placeholder text of the main filter in frontend/src/modules/member/config/filters. ​

🤖 Generated by Copilot at 57c829d

Search by name or email A new filter option Spring cleaning the frontend

Why

How

🤖 Generated by Copilot at 57c829d

  • Add a new option to filter members by email address in the identities filter (link)
  • Update the placeholder text of the member search filter to include email (link)

Checklist ✅

  • [ ] Label appropriately with Feature, Improvement, or Bug.
  • [ ] Add screehshots to the PR description for relevant FE changes
  • [ ] New backend functionality has been unit-tested.
  • [ ] API documentation has been updated (if necessary) (see docs on API documentation).
  • [ ] Quality standards are met.

peoray avatar Sep 12 '23 14:09 peoray

Hey @peoray, if you need any further help on this one let me know 😄

joanagmaia avatar Sep 20 '23 11:09 joanagmaia

@joanagmaia I do. I left a comment on the issue itself :)

peoray avatar Sep 20 '23 11:09 peoray

@joanagmaia how can I make sure Email is added as one of the select options? I'm getting an unknown field operator error Unknown field or operator: email!

peoray avatar Sep 26 '23 13:09 peoray

@joanagmaia how can I make sure Email is added as one of the select options? I'm getting an unknown field operator error Unknown field or operator: email!

You cannot place email inside identities. You need to treat them almost as separate filters.

  • So if it's a platform you use what we already have in apiFilterRenderer.
  • If it's email, you need to parse with customized logic, and you need to use emails key instead of email. You can check how we do for search bar in modules/member/config/filters/main.ts
  • If it's both you probably need to have an or operator to treat them both differently

joanagmaia avatar Oct 03 '23 10:10 joanagmaia

@joanagmaia to iterate:

  • When only platforms are selected
  • when only email is selected
  • when both platforms and email are selected

I have updated the code with the current work progress, but it still doesn't work as expected.

One more thing, for the first option, if multiple options are selected, for example, Twitter and DEV, what's the expected result?

peoray avatar Oct 09 '23 09:10 peoray

@joanagmaia Any update on this? Would like to get it over the finish line 🙏🏿

peoray avatar Oct 15 '23 08:10 peoray

@joanagmaia Any update on this? Would like to get it over the finish line 🙏🏿

Hey @peoray, sorry for the delay! I'll look into the code and your comment and check what's the issue. I'll make an effort to reply to you today

joanagmaia avatar Oct 16 '23 09:10 joanagmaia

Hey @peoray, just took a look at your comments and functionality-wise wise it is looking good to me. When multiple platforms are selected, we should display members that have at least one of the selected platforms

I'm gonna review the code as well to make sure it is good to go 😄

joanagmaia avatar Oct 18 '23 10:10 joanagmaia

Hey @peoray, not sure if you missed on my message, but everything looks ok with PR, just missing to fix lint issues. You can run npm run lint to check them out

joanagmaia avatar Oct 26 '23 09:10 joanagmaia

@joanagmaia good to go :)

peoray avatar Oct 26 '23 20:10 peoray

@joanagmaia what's the status on this :)?

peoray avatar Nov 20 '23 23:11 peoray