Waterwheels using Archwood Planks, rendering defaults to Blue Archwood

[Lucky-56]

would be better if this would be changable by adding a subMaterial or something like that

but this just fixes #8384 in regards to having a mismatched logtype

replaces #8385

[VoidLeech]

Do want to note that this ignores the other colors or archwood (the 3 others from Ars Nouveau and a 4th from the Ars Elemental addon), which might be acceptable (this is for example what moonlight/everycomp do, but not Create with cutting recipes) but does feel slightly less nice.

[Lucky-56]

I planned for the application of woodtypes to accept logs aswell, but I haven't gotten around to try it further

[Lucky-56]

I'll continue work on it on my main (1.21.1) branch, and will come back if I have good results should I put this PR on hold until then?

also, any other mods I could test the multilog thing with other than ars nouveau and elemental?

[Lucky-56]

I'll get back to this tommorow, I'm overwhelmed...

[RaymondBlaze]

I planned for the application of woodtypes to accept logs aswell, but I haven't gotten around to try it further

What about making it cycle between different logs when clicked with the same planks?

Also maybe the plank -> wood type -> log conversion could move to using a SimpleRegistry.Multi<Block, BlockState>, which can separate different conversion logic and make handling special cases (like the archwood) easier.

[Lucky-56]

I planned for the application of woodtypes to accept logs aswell, but I haven't gotten around to try it further

What about making it cycle between different logs when clicked with the same planks?

Also maybe the plank -> wood type -> log conversion could move to using a SimpleRegistry.Multi<Block, BlockState>, which can separate different conversion logic and make handling special cases (like the archwood) easier.

I thought of this, but I just didn't quite like the idea having to click 5 times on each waterwheel to get flashing archwood

[Lucky-56]

so I think I'll make it possible to use logs or planks, and maybe also look at how copycats use the offhand <.<

[RaymondBlaze]

I thought of this, but I just didn't quite like the idea having to click 5 times on each waterwheel to get flashing archwood

Yeah that's reasonable. The suggested SimpleRegistry<Block, BlockState> should still be a valid option for better implementing the special behaviors. Or probably SimpleRegistry<Block, Pair<BlockState, BlockState>> since we now allow using either log or planks to specify a pair of plank and log as the material.

[Lucky-56]

man, I was dreaming about this the whole time while waking up and falling back asleep 😅

EDIT: once again I'm plunging myself into something that overwhelmes me... halting for now

[IThundxr]

For now i think this is fine, if there's any other similar issues with other mods we can look into a better fix