Create icon indicating copy to clipboard operation
Create copied to clipboard

Ensure All Compat Recipies are in Correct Folders

Open Attack8 opened this issue 1 year ago • 8 comments

Move/reformat recipes to all follow recipe_type/compat/mod_id

Attack8 avatar Jan 30 '25 03:01 Attack8

Where are we at with this as I keep getting requests about support being broken for bwg

JT122406 avatar Mar 02 '25 23:03 JT122406

Please be patient, the team will merge prs when they are ready

Attack8 avatar Mar 02 '25 23:03 Attack8

Due to #7861, datagen should now be added to the Create{RecipeType}Gen classes instead of {RecipeType}Gen.

VoidLeech avatar May 10 '25 14:05 VoidLeech

@Attack8, this pull request has merge conflicts with the target branch. Please merge the latest changes and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks!

github-actions[bot] avatar Oct 25 '25 23:10 github-actions[bot]

Okay, everything should be fixed now, and I removed any unintentional whitespace changes to lower the diff

Attack8 avatar Oct 27 '25 21:10 Attack8

I'm also not 100% sure why the run is failing Edit: It does, however, seem to be consistent with the behavior on the base branch so I don't believe I broke it

Attack8 avatar Oct 27 '25 21:10 Attack8

There's some failing gametests, noticed it on one of my PRs also and on /dev. It's not always the same ones either.

Would recommend renaming this PR to be closer to its purpose (: (and since you mentioned wanting to pick up an issue related to datagen compat just make that a non-stacked PR since that's much easier to review)

VoidLeech avatar Oct 27 '25 21:10 VoidLeech

I will rename this, also yes, I will try to avoid stacked PRs in the future and have in the past, it was just difficult with these since the others (which recently got merged) took such a long time

Attack8 avatar Oct 27 '25 22:10 Attack8