Alexander Leschanz
Alexander Leschanz
The test i added tests both serialization and deserialization, since the RawConfig can't be constructed programmatically. Should i rename it/the full_deserialize test or remove the full_deserialize test, since the new...
@bconn98 So the actual implementation is correct?
@bconn98 cfg is now a constant. Would you mind checking my implementation for correctness, as I didn't write any custom serializers, however the `deserialize` implementation uses a custom deserializer?
@bconn98
@bconn98 I have a question: The humantime crate used for serializing/deserializing the `refresh_rate` option in `RawConfig` serializes `1 minute` (as a Rust Duration) into the the string `1m`. This means...
@bconn98 In the latest commit serialization of filters and appenders is fixed. Currently 54 tests are passing with 1 failed and 1 ignored. The current output (of `config::raw::test::full_serialize`) is: ```yaml...
@bconn98 So is the PR ready?
@bconn98 @estk @sfackler @demonov Is this PR ready for review/merge?