CreateAPI icon indicating copy to clipboard operation
CreateAPI copied to clipboard

Added support for enum.protocols feature

Open aaronsky opened this issue 2 years ago • 3 comments

Addresses #171.

Creates a new enum.protocols option that is used to drive protocol conformance for enums of strings, which are the only currently supported enum variety. Currently does not do any of the redundant protocol stripping that entities.protocols does.

aaronsky avatar Mar 10 '23 13:03 aaronsky

@liamnichols I believe this both addresses the test failures and your feedback. The PR suddenly got huge because I needed to regenerate snapshots, since protocols are sorted by name now.

aaronsky avatar Mar 17 '23 21:03 aaronsky

@liamnichols any update on this?

aaronsky avatar May 16 '23 03:05 aaronsky

Any update on this PR? I would like to add Sendable on enum like we can do on entities.protocols 🙏

damien-nd avatar Aug 08 '24 14:08 damien-nd

Any update on this ?

nbapps avatar Dec 04 '24 16:12 nbapps

I'll add my voice to the chorus here. It would be great to get this merged.

mgrider avatar May 14 '25 18:05 mgrider

~~...although looking closer, I can see some reasons we wouldn't want this version of this feature. For one thing, why is enums expected to be a separate part of the config from entities? It should be parallel (at the same level as) protocols underneath entities, IMO.~~ (Ignore me here, I was just confused.)

Also, I'm not sure why this PR had to regenerate all those test results. That's probably something that should be figured out before this could get merged.

mgrider avatar May 19 '25 17:05 mgrider

As I stated here, snapshots needed regeneration because of this change

aaronsky avatar May 29 '25 23:05 aaronsky