SmartSim icon indicating copy to clipboard operation
SmartSim copied to clipboard

Update SmartSim to use Dragon V0.10

Open MattToast opened this issue 1 year ago • 1 comments

Update SmartSim to use Dragon V0.10 by:

  • [x] Removing the use of Dragon attributes that have been removed in Dragon V0.10.
  • [x] Updating smart build --dragon ... to fetch Dragon V0.10 once all required assets are hosted

MattToast avatar Oct 17 '24 21:10 MattToast

Codecov Report

:x: Patch coverage is 35.84906% with 34 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 81.82%. Comparing base (d7d979e) to head (eb7639b). :warning: Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragonBackend.py 27.65% 34 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
- Coverage    83.91%   81.82%   -2.09%     
===========================================
  Files           83       84       +1     
  Lines         6284     7081     +797     
===========================================
+ Hits          5273     5794     +521     
- Misses        1011     1287     +276     
Files with missing lines Coverage Δ
smartsim/_core/utils/__init__.py 100.00% <ø> (ø)
smartsim/_core/utils/helpers.py 91.58% <100.00%> (+0.12%) :arrow_up:
smartsim/_core/launcher/dragon/dragonBackend.py 35.35% <27.65%> (-0.11%) :arrow_down:

... and 46 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 18 '24 19:10 codecov[bot]

@MattToast there have been some updates to Dragon's ProcessGroup management which require some modification of this code. Do you want me to take care of that by pushing to your branch?

al-rigazzi avatar Dec 09 '24 23:12 al-rigazzi

@MattToast there have been some updates to Dragon's ProcessGroup management which require some modification of this code. Do you want me to take care of that by pushing to your branch?

@al-rigazzi By all means! Feel free to take over ownership of this branch and push whatever changes are necessary!!

MattToast avatar Dec 09 '24 23:12 MattToast