Upgrade Watchdog Dependency

[MattToast]

Description

Currently SmartSim relies on watchdog>=3.0.0 to manage listening for file system events so that the telemetry monitor can properly track the statuses of launched jobs.

Unfortunately on Febuary 6th, watchdog released version 4.0.0, which exposed their typehints, and as such surfaced some lingering type errors within SmartSim. As such the MyPy step of the SmartSim CI began failing. I order to mitigate this a patch PR (#477) addressed the issue by simply pinning watchdog<4.0.0.

From my (very quick, non-thorough) scan through the watchdog change log it doesn't appear as though there are any changes that should affect how we use watchdog. These errors appear to only be static analysis errors. As such, we should make it a priority to address these errors and allow for upgrading watchdog as dependency.

Justification

It doesn't make a whole lot of sense to tie SmartSim to old versions of dependencies, especially if the errors are strictly static analysis errors. Plus, it would be nice to be able to offer type safety in the telemetry monitor when interacting with watchdog.

Acceptance Criteria

• [ ] Remove the upper pin of watchdog from the setup.py
• [ ] Build SmartSim with the newer version of the watchdog and ensure the (full, including WLM) test suite passes
• [ ] Address any mypy errors
• [ ] Ensure that the GH actions are passing