SmartSim icon indicating copy to clipboard operation
SmartSim copied to clipboard

Dragon Launcher Prototype

Open al-rigazzi opened this issue 2 years ago • 1 comments

This is the first prototype of the new Dragon-based launcher.

Issues to fix (or to defer to a future PR):

  • [x] Several telemetry test errors
  • [ ] Missing batch settings for Dragon launcher
  • [x] Use Process Groups for MPI-based applications - we have process groups but Dragon team is working on a more complete API

al-rigazzi avatar Jan 30 '24 16:01 al-rigazzi

Codecov Report

Attention: Patch coverage is 56.24242% with 361 lines in your changes are missing coverage. Please review.

Project coverage is 85.21%. Comparing base (6f800b1) to head (730889f).

:exclamation: Current head 730889f differs from pull request most recent head befb6b6. Consider uploading reports for the commit befb6b6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           dragon_launcher     #470      +/-   ##
===================================================
- Coverage            90.70%   85.21%   -5.50%     
===================================================
  Files                   65       75      +10     
  Lines                 4498     5303     +805     
===================================================
+ Hits                  4080     4519     +439     
- Misses                 418      784     +366     
Files Coverage Δ
smartsim/_core/launcher/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/launcher/colocated.py 97.82% <100.00%> (+0.02%) :arrow_up:
smartsim/_core/launcher/step/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/launcher/step/step.py 100.00% <ø> (ø)
smartsim/_core/schemas/__init__.py 100.00% <100.00%> (ø)
smartsim/_core/schemas/dragonResponses.py 100.00% <100.00%> (ø)
smartsim/_core/schemas/utils.py 100.00% <100.00%> (ø)
smartsim/_core/utils/helpers.py 91.96% <100.00%> (ø)
smartsim/_core/utils/redis.py 80.76% <100.00%> (+0.37%) :arrow_up:
smartsim/experiment.py 85.80% <100.00%> (ø)
... and 19 more

... and 1 file with indirect coverage changes

codecov[bot] avatar Jan 31 '24 10:01 codecov[bot]