curationmarkets

curationmarkets copied to clipboard

ppragma instead of pragma

snaketh4x0r

ainoya

@simondlr This PR: - Add gitignore - add backbone of truffle for future testing - Refactor the `CurationMarkets.sol` by splitting it in different files to help future development Please note...

AntMarras

In order for other contracts to use the rankings, it would be useful to have them on-chain. An order statistic tree will be useful for doing this: https://github.com/drcode/ethereum-order-statistic-tree It "can...

simondlr

`costOfCoupon = (BaseCost + BaseCost*(1.000001618^AvailableSupply)+BaseCost*AvailableSupply/1000)` In this formula, if AvailableSupply = 0, when the constructor is called, CostOfCoupon = 2*BaseCost. Is it the expected behavior? The naming seems to be...

pranay01

Possible Issue with Calculating Guaranteed Loss

6

This is a more-game-theoretic-issue than bug-in-the-code. I’m also not totally positive about it but would love to hear your thoughts. Assuming: At some point in the future, the total supply...

naterush

Non-constant gas costs for token minting

1

https://github.com/ConsenSys/curationmarkets/blob/master/CurationMarkets.sol#L71 Implements a correct yet very expensive system for token minting that linearly increases in execution price with the token amount being bought. I propose modeling this along the lines...

GNSPS

Supply increase/decrease concordant with EIP 621

1

I think https://github.com/ConsenSys/curationmarkets/blob/master/CurationMarkets.sol#L63 & https://github.com/ConsenSys/curationmarkets/blob/master/CurationMarkets.sol#L97 could be concordant with https://github.com/ethereum/EIPs/pull/621 and contribute momentum to help push the standard further (given the groundbreaking potential these contracts have for innovation 👏 ).

GNSPS

simondlr