conflux-rust icon indicating copy to clipboard operation
conflux-rust copied to clipboard

MAX_PAYLOAD_SIZE in connection.rs and MAX_PACKET_SIZE in parameter.rs are not consistent. We should consider put them together.

Open fanlong opened this issue 6 years ago • 1 comments

fanlong avatar Apr 17 '20 17:04 fanlong

The MAX_PACKET_SIZE is currently a rough and conservative estimation for the message size. It is now only used when constructing message for returning blocks. Making MAX_PACKET_SIZE and MAX_PAYLOAD_SIZE consistent requires some design pattern improvement in the network layer, which we can first discuss about it.

sparkmiw avatar Apr 18 '20 08:04 sparkmiw