Conduit icon indicating copy to clipboard operation
Conduit copied to clipboard

refactor(database,authorization,grpc-sdk): Mongo authz query aggregations

Open ChrisPdgn opened this issue 2 years ago • 2 comments

This PR refactors the way we use access control in mongoose. Now, authorization module doesn't create views but returns authorized queries that calculate the accessible docs through aggregation.

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [x] Refactor
  • [ ] Build-related changes
  • [ ] Other (please describe)

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

The PR fulfills these requirements:

  • [x] It's submitted to the main branch
  • [ ] When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature

Other information:

ChrisPdgn avatar Jul 10 '23 14:07 ChrisPdgn

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Jul 10 '23 14:07 ghost

This seems to be working as expected.

We should ideally delete any View docs for Mongo users, but given how the gRPC API already exposed view creation we could be deleting non-authz ones explicitly created by the users themselves.

kon14 avatar Nov 20 '23 13:11 kon14